Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs site version selector broken #3590

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented May 23, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

the docs site version selector dropdown is broken
image

Fixed the version selector. Also added version information warning as with ArgoCD

image

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (4f1edbe) to head (8740c7f).

Current head 8740c7f differs from pull request most recent head d1ae763

Please upload reports for the commit d1ae763 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3590   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files         156      156           
  Lines       17964    17964           
=======================================
  Hits        14420    14420           
  Misses       2631     2631           
  Partials      913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 23, 2024

Go Published Test Results

2 163 tests   2 163 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit c125d24.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 23, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 26m 8s ⏱️
111 tests  99 ✅  6 💤  6 ❌
456 runs  420 ✅ 24 💤 12 ❌

For more details on these failures, see this check.

Results for commit c125d24.

♻️ This comment has been updated with latest results.

@yyzxw yyzxw force-pushed the fix/version-selector-broken branch from fb0b947 to 8740c7f Compare June 17, 2024 15:41
@kostis-codefresh
Copy link
Member

kostis-codefresh commented Jun 21, 2024

@zachaller I updated read-the-docs and from now on it will create Pull Request previews for the docs. This way we can check the rendering of docs for PRs like this that affect docs.

It will take effect in the next commit/PR that somebody opens.

@kostis-codefresh kostis-codefresh added the docs Needs documentation/release notes label Jun 21, 2024
@zachaller zachaller force-pushed the fix/version-selector-broken branch from 8740c7f to d1ae763 Compare June 21, 2024 14:51
@zachaller
Copy link
Collaborator

Signed-off-by: xiaowu.zhu <[email protected]>
Signed-off-by: root <[email protected]>
@zachaller zachaller force-pushed the fix/version-selector-broken branch from d1ae763 to c125d24 Compare June 21, 2024 15:55
@kostis-codefresh
Copy link
Member

@yyzxw many thanks for addressing this 🙂

@zachaller zachaller merged commit c43f4fb into argoproj:master Jun 21, 2024
21 checks passed
zachaller pushed a commit that referenced this pull request Jun 21, 2024
zachaller pushed a commit that referenced this pull request Jun 21, 2024
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.5 cherry-pick/release-1.6 cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases docs Needs documentation/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants