Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when Rollout has pingpong and stable/canary service defined, only alb traffic management uses pingpong. #3628

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

mayzhang2000
Copy link
Contributor

…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Go Published Test Results

2 163 tests   2 163 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit b57e6b7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 25m 22s ⏱️
111 tests 100 ✅  6 💤 5 ❌
452 runs  421 ✅ 24 💤 7 ❌

For more details on these failures, see this check.

Results for commit b57e6b7.

♻️ This comment has been updated with latest results.

…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.

Signed-off-by: mayz985 <[email protected]>
Signed-off-by: mayz985 <[email protected]>
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.26%. Comparing base (32d50b7) to head (b57e6b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3628   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files         156      156           
  Lines       17969    17970    +1     
=======================================
+ Hits        14423    14424    +1     
+ Misses       2634     2632    -2     
- Partials      912      914    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mayz985 <[email protected]>
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.0% Duplication on New Code

See analysis details on SonarCloud

@mayzhang2000 mayzhang2000 marked this pull request as ready for review June 12, 2024 16:21
@zachaller zachaller merged commit 7df3d17 into argoproj:master Jun 12, 2024
23 checks passed
zachaller pushed a commit that referenced this pull request Jun 13, 2024
…y alb traffic management uses pingpong. (#3628)

* fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.

Signed-off-by: mayz985 <[email protected]>

* fix lint error

Signed-off-by: mayz985 <[email protected]>

* added e2e

Signed-off-by: mayz985 <[email protected]>

---------

Signed-off-by: mayz985 <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants