-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: when Rollout has pingpong and stable/canary service defined, only alb traffic management uses pingpong. #3628
Conversation
Go Published Test Results2 163 tests 2 163 ✅ 2m 54s ⏱️ Results for commit b57e6b7. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 25m 22s ⏱️ For more details on these failures, see this check. Results for commit b57e6b7. ♻️ This comment has been updated with latest results. |
…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]>
Signed-off-by: mayz985 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3628 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 156 156
Lines 17969 17970 +1
=======================================
+ Hits 14423 14424 +1
+ Misses 2634 2632 -2
- Partials 912 914 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mayz985 <[email protected]>
Quality Gate passedIssues Measures |
…y alb traffic management uses pingpong. (#3628) * fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]> * fix lint error Signed-off-by: mayz985 <[email protected]> * added e2e Signed-off-by: mayz985 <[email protected]> --------- Signed-off-by: mayz985 <[email protected]>
…StableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.