Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to canary endpoint feature to support mupliple AWS ALB. #709 #710

Closed
jukops opened this issue Sep 14, 2020 · 6 comments
Closed

Allow to canary endpoint feature to support mupliple AWS ALB. #709 #710

jukops opened this issue Sep 14, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@jukops
Copy link

jukops commented Sep 14, 2020

Summary

Our application has 2 ALBs. but looks support only an ALB. I'm using alb ingress controller for mapping between ingress and AWS ALB.

  • currently yaml.
    Only that app-ext ingress can receive canary traffic when deployment. Other ingress(ALB) which is connected to app pods should receive stable traffic as 100% when deployment.
  strategy:
    canary:
      canaryService: app-canary
      stableService: app-stable
      trafficRouting:
        alb:
          ingress: app-ext
          servicePort: 80
      steps:
      - setWeight: 5
      - pause: {}

Use Cases

Our app has internal alb for VPC internal connection and has external alb for enduser(client). so required multiple ALBs.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@jukops jukops added the enhancement New feature or request label Sep 14, 2020
@jessesuen
Copy link
Member

Our app has internal alb for VPC internal connection and has external alb for enduser(client). so required multiple ALBs.

I think this use case makes sense to support multiple alb ingress references.

@jukops
Copy link
Author

jukops commented Sep 18, 2020

Our app has internal alb for VPC internal connection and has external alb for enduser(client). so required multiple ALBs.

I think this use case makes sense to support multiple alb ingress references.

Thanks for kindly reply.
Actually, This is the feature that I need. But I cannot attach multiple ALB now :( I'm using only an ALB due to this problem.
If it's implemented, It would be really good.

@allupaku
Copy link

allupaku commented Dec 8, 2021

Do you think a definition like this would suffice this use case ?

strategy:
    canary:
      canaryService: app-canary
      stableService: app-stable
      trafficRouting:
        alb:
          - ingress: app-ext
            servicePort: 443
         - ingress: app-interal
            servicePort: 80

@n888
Copy link
Contributor

n888 commented Apr 9, 2022

@allupaku that looks good to me 👍

Currently working around this by deploying 1 Rollout per ALB, and then each Rollout is promoted individually.

Small request: Could we fix the typo in the issue title?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

This issue is stale because it has been open 60 days with no activity.

@zachaller
Copy link
Collaborator

Closing in favor of #2471 becuase of the added patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants