From 5e8e2facf9d88fe7a7d5b4aa0764cc5414910b9a Mon Sep 17 00:00:00 2001 From: zachaller Date: Fri, 4 Nov 2022 11:08:51 -0500 Subject: [PATCH] fix: set gopath in makefile We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use `go env GOPATH` to set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance. Signed-off-by: zachaller --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index e04235a207..0d6814ea51 100644 --- a/Makefile +++ b/Makefile @@ -23,6 +23,7 @@ E2E_INSTANCE_ID ?= argo-rollouts-e2e E2E_TEST_OPTIONS ?= E2E_PARALLEL ?= 1 E2E_WAIT_TIMEOUT ?= 120 +GOPATH ?= $(shell go env GOPATH) override LDFLAGS += \ -X ${PACKAGE}/utils/version.version=${VERSION} \