From e7373bba137455bd5526d7a971f3c16876975912 Mon Sep 17 00:00:00 2001 From: mitchell amihod <4623+meeech@users.noreply.github.com> Date: Sat, 1 Apr 2023 23:28:32 -0400 Subject: [PATCH 1/2] doc(examples): interval requires count doc(examples): moved other count up next to interval for visibility Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com> --- examples/analysis-templates.yaml | 2 +- examples/cluster-analysis-templates.yaml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/analysis-templates.yaml b/examples/analysis-templates.yaml index 84dde3b1c1..02bde8d8c4 100644 --- a/examples/analysis-templates.yaml +++ b/examples/analysis-templates.yaml @@ -10,6 +10,7 @@ metadata: spec: metrics: - name: pass + count: 1 interval: 5s failureLimit: 1 provider: @@ -24,7 +25,6 @@ spec: args: [exit 0] restartPolicy: Never backoffLimit: 0 - count: 1 --- # This AnalysisTemplate will run a Kubernetes Job every 5 seconds, with a 50% chance of failure. # When the number of accumulated failures exceeds failureLimit, it will cause the analysis run to diff --git a/examples/cluster-analysis-templates.yaml b/examples/cluster-analysis-templates.yaml index 00c98c355e..5e1ae76adb 100644 --- a/examples/cluster-analysis-templates.yaml +++ b/examples/cluster-analysis-templates.yaml @@ -5,6 +5,7 @@ metadata: spec: metrics: - name: pass + count: 1 interval: 5s failureLimit: 1 provider: @@ -18,4 +19,4 @@ spec: command: [sh, -c] args: [exit 0] restartPolicy: Never - backoffLimit: 0 \ No newline at end of file + backoffLimit: 0 From b8720b8b102b38814954a16e72c938b4f0080596 Mon Sep 17 00:00:00 2001 From: mitchell amihod <4623+meeech@users.noreply.github.com> Date: Sat, 1 Apr 2023 23:40:15 -0400 Subject: [PATCH 2/2] fix: noticed typo in bug_report template while making bug report Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/bug_report.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index fd7d7aa972..2a7fef17f4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -11,7 +11,7 @@ assignees: '' Checklist: * [ ] I've included steps to reproduce the bug. -* [ ] I've inclued the version of argo rollouts. +* [ ] I've included the version of argo rollouts. **Describe the bug** @@ -49,4 +49,4 @@ kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout= **Message from the maintainers**: -Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍. \ No newline at end of file +Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.