Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakey tests tracking #10231

Closed
1 task
isubasinghe opened this issue Dec 14, 2022 · 3 comments
Closed
1 task

Flakey tests tracking #10231

isubasinghe opened this issue Dec 14, 2022 · 3 comments
Labels
area/build Build or GithubAction/CI issues P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important solution/duplicate This issue or PR is a duplicate of an existing one type/bug type/tech-debt

Comments

@isubasinghe
Copy link
Member

isubasinghe commented Dec 14, 2022

A copy of #7133 to address more flakey tests

This issue is for tracking flakey tests, so we can see how flakey they are.

Flakey tests are often not actually flakey, they instead revealing and edge-case bug that is caused by rare events, such as API disruption.

If a test appears to be flakey, then we simply disable it and wait for the author of the test (and therefore the feature) to investigate it. Either way, it is ideally their responsibility.

Why do we need to aggressively skip flakey tests?

Consider a test suite with 5 tests that each fail on 5% of the time. How often will the whole suite fail? Hint: it is much greater that 5x5%!

https://testing.googleblog.com/2016/05/flaky-tests-at-google-and-how-we.html

Tests

please comment all flakey tests here and I will update this list.

@juliev0
Copy link
Contributor

juliev0 commented Dec 14, 2022

Thanks for tracking these. I actually have a similar issue here. I didn't realize Alex had created an issue before.

Hmm, I wonder if we should have a label for this?

@isubasinghe
Copy link
Member Author

Ah thanks for letting me know about that @juliev0, I will close this issue in that case.

But yes a "misc"or dedicated label would be nice

@juliev0
Copy link
Contributor

juliev0 commented Dec 14, 2022

Ah thanks for letting me know about that @juliev0, I will close this issue in that case.

But yes a "misc"or dedicated label would be nice

I noticed an "area/build" label applied to the other issue - I guess that's supposed to be for this.

@agilgur5 agilgur5 added type/bug P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important solution/duplicate This issue or PR is a duplicate of an existing one and removed type/feature Feature request labels Sep 8, 2023
@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important solution/duplicate This issue or PR is a duplicate of an existing one type/bug type/tech-debt
Projects
None yet
Development

No branches or pull requests

3 participants