Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates should automatically apply to release-3.4 and release-3.5 #13014

Open
isubasinghe opened this issue May 7, 2024 · 4 comments
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/dependencies PRs and issues specific to updating dependencies type/feature Feature request type/security Security related

Comments

@isubasinghe
Copy link
Member

Summary

As the title states, security updates should immediately be available in release channels.

Use Cases

It is difficult to individually perform releases and currently is a manual process, which also is to say that it is error prone, humans may accidentally miss out on critical security fixes when rolling a new release. While the end goal would be some kind of full automation to the release process, we could setup the security updates from dependabot to be automated.

@isubasinghe isubasinghe added type/feature Feature request type/dependencies PRs and issues specific to updating dependencies labels May 7, 2024
@agilgur5 agilgur5 added type/security Security related area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels May 7, 2024
@agilgur5 agilgur5 changed the title Security updates should also automatically apply to release-3.4 and release-3.5. Security updates should automatically apply to release-3.4 and release-3.5 May 8, 2024
@agilgur5
Copy link
Contributor

agilgur5 commented May 8, 2024

Sounds like a subissue of #12592.

Afaik, dependabot doesn't run on other branches, so this would be largely the same as what we discussed in #12592, automatically cherry-picking into currently supported branches.

which also is to say that it is error prone

Due to that, there can still be a merge conflict on cherry-picking / backporting, especially with deps, so this may never be fully automated either.

we could setup the security updates from dependabot to be automated.

Since dependabot is only doing security updates now after #12487, we could detect these.

Otherwise, we do have to manually do some updates (as they're major bumps or require code changes etc), and there isn't necessarily a good way to detect those other than the labels (which have to be manually added)

@isubasinghe
Copy link
Member Author

isubasinghe commented May 9, 2024

I didn't know that dependabot doesn't run on other branches, that is a shame to hear.

I do have a dirty ugly hack for this, I can create two forks of workflows and each set the default branch to be release-3.4 and release-3.5. This way there should be automatic updates to those forks.
From there I can push those changes here.
It won't be completely automatic, but it will resolve the manual conflict resolution.

I feel like I deserve some abuse for this proposal hahaha, it is such a hack but should keep us going.

@xnox
Copy link

xnox commented Aug 10, 2024

One can ask dependendabot to run on branches.... but it only does security PRs on the main one.
Hence many people ...... create a separate git repository for stable branch to be set as default just to get those PRs....... i know.

@agilgur5
Copy link
Contributor

but it only does security PRs on the main one

ofc classic dependabot limitations... 🙃
security PRs require dependabot security alerts, which afaik aren't even configurable? Let alone run on branches 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/dependencies PRs and issues specific to updating dependencies type/feature Feature request type/security Security related
Projects
None yet
Development

No branches or pull requests

3 participants