-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI does not show all running workflows (it used to) / UI and argo list
differ (missing running workflows)
#9696
Comments
You are missing some permissions on your service account. |
@terrytangyuan Are you saying this is the cause for the regression I am seeing? The workflows do show up when a transition occurs. Also completed workflows are shown correctly. Just running ones are not. Also I installed argo from the install.yaml as per the release, so the roles and cluster roles are the vanilla roles from v3.4.0 – this should surely not miss any permissions? |
This indicates that you are archiving the workflows. Could you check if they are in your list of archived workflows? |
First things first. So I did patch the respective role with the missing permissions. I changed the - apiGroups:
- argoproj.io
resources:
- workflowtaskresults
verbs:
- list
- watch
- deletecollection to - apiGroups:
- argoproj.io
resources:
- workflowtaskresults
verbs:
- list
- watch
- deletecollection
- create
- patch The warnings are now gone. Here is the complete logs from a rerun. However the problem that I am describing exists in the same way. Wait Container logs:
Workflow Controller Log
|
@terrytangyuan Yes we are archiving workflows. But the problem here is that the workflow is not listed while it is running. Once the workflow transitions to a new node in the flow and the list of workflows in the UI is open while it does it will show in the list. ...and yes, they are in the archived workflows, but only after they completed. |
@scravy Can you check if a namespace filter is populated with the cookie's default value? |
@sarabala1979 I am not sure what you mean by "the cookie's default value". In the UI I do have a filter set for namespace = argo – but then again we do everything in that namespace and all workflows show up here, and it used to work in previous versions or argo, so not sure how this would affect anything. I looked at the cookies and there's four cookies set: |
It also happens to me. |
When you refresh the list view, do they appear as expected? |
@scravy Is it working as expected on v3.3? |
When I refresh the page it always show the list incomplete and after some time it loads all the workflows. I noticed the issue is calling this endpoint:
As soon as this error appears in the browser console the UI loads all the workflows. |
@terrytangyuan No, they do not appear when the list view is refreshed. On the contrary: When they appear and you then refresh they are gone again. Until the workflow transitions to a new node and pops up again. @sarabala1979 We actually made a version jump from 3.1 where it used to work to 3.4 where it doesn't. I can try setting up a 3.3 later today and see whether the problem exists or not. @ese On my installation I do not actually see any errors in the UI / dev console. As I mentioned above once a workflow event comes in the workflow is shown, but not all workflows. Are you sure all missing workflows are being shown once you hit that error? |
Seeing the same issue. We upgraded from 3.3.8 to 3.4.1 recently. |
I setup a 3.3 on our dev cluster and things work as expected. Both 3.4.0 and 3.4.1 show the regression as described here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions. |
There is an error in your console, but I don’t see the diagnostics. Can you please add any Argo Server logs that show more details. |
@alexec Here are argo server logs from running the workflow which I showed in the beginning.
Since opening the ticket we upgraded to Argo 3.4.4 and the problem still persists. Anything I can do to share more information with you? I was on sabbatical the past two months but can react quickly now. |
I can confirm that this works as expected in 3.3.9 but not in 3.4.0 |
I dug into the (very large) changelog for 3.4.0-rc1 and the one thing that seemed potentially related to this is #8596, which added a date range filter to the UI. Specifically, this added a new default to the UI (this line) to only show the past month.
When you remove the date filter, does this still occur? With the Workflow only appearing after a transition, that sounds it could be because one of the statuses does not yet exist. The UI seems to exclusively filter on I may be able to fix the UI transition issue based on the above, but the CLI and UI having different defaults seems like it may be a bit unintuitive. |
Looks like this may have been partially fixed by #9909 (released in 3.4.4) for |
Was unable to reproduce on latest 3.5.0-rc1+. This seems like it was indeed fixed by #9909 as only a We may want to remove the new default in 3.4.0+ of showing only last month first if users are confused by that. Then the UI would by default match the CLI as well. I'll leave that decision to more tenured contributors + maintainers to decide. |
Ok I did find a pretty bad bug in the date filtering logic: when either of the date filters were cleared, no Workflows would show, as they were comparing dates against I submitted a fix for this in #11792 That should only have impact if one of the date filters were clear, which was something I didn't test for when I tried repro'ing in my previous comment (I only tested with date filters). |
I've gone ahead and done this in #11840. With that PR, UI and CLI should now match. |
argo list
differ (missing running workflows)
Pre-requisites
:latest
What happened/what you expected to happen?
When I am submitting a workflow in the UI it is shown in the list of running workflows. When refreshing this page all workflows should be listed.
We just upgraded to argo 3.4.0 and not all running workflows are shown in the UI. When you wait long enough eventually workflows pop up. In our day to day work we noticed that workflows seem to be added to the UI once a transition happens, i.e. when a new step is entered in the workflow.
In short: The output of
argo list
and the workflows shown in the UI are not the same. Some running flows are missing. They are being added once they transition from one node to another while the UI is shown.Version
3.4.0
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: