You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now a Tracer interface is added to support adding some fields to the logger https://github.com/argoproj/gitops-engine/blob/master/pkg/utils/tracing/api.go#L10.
We want to add real opentracing/opentelemetry support based on this interface. However, to support real tracing, an additional argument ctx needs to be passed to the StartSpan interface so that the span context can be propagated.
Additionaly, it would be great to refactor this interface. It is hard to add opentracing span options using the current interface.
The text was updated successfully, but these errors were encountered:
Now a
Tracer
interface is added to support adding some fields to the logger https://github.com/argoproj/gitops-engine/blob/master/pkg/utils/tracing/api.go#L10.We want to add real opentracing/opentelemetry support based on this interface. However, to support real tracing, an additional argument
ctx
needs to be passed to theStartSpan
interface so that the span context can be propagated.Additionaly, it would be great to refactor this interface. It is hard to add opentracing span options using the current interface.
The text was updated successfully, but these errors were encountered: