Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new GitLab service to support creating a commit status and creating a comment to the associated merge requests #137

Open
nan-yu opened this issue Dec 6, 2022 · 2 comments · May be fixed by #239
Open

Add a new GitLab service to support creating a commit status and creating a comment to the associated merge requests #137

nan-yu opened this issue Dec 6, 2022 · 2 comments · May be fixed by #239

Comments

@nan-yu
Copy link
Contributor

nan-yu commented Dec 6, 2022

There is no GitLab integration for status update. The only way is to configure the webhook to send a REST request, but it only supports one single REST call.

If we want to create both a commit status and a comment to the associated merged requests, it's better to have a GitLab service.
@ishworg
Copy link

ishworg commented Feb 14, 2023

Bump! any example/toy? thanks!

@aslafy-z aslafy-z linked a pull request Nov 3, 2023 that will close this issue
Draft
@aslafy-z
Copy link

aslafy-z commented Nov 3, 2023 •
edited
Loading

I'm working on this topic at #239.
I'm not sure what is the desired behavior for Deployments. Should all triggers create a new deployment? If not, how to distinguish the deployment to update from others? Should we delete deployments?
Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add gitlab service aslafy-z/argoproj-notifications-engine
3 participants
@aslafy-z @ishworg @nan-yu