Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jest Configuration #111

Closed
gregberge opened this issue Aug 16, 2018 · 3 comments
Closed

Use Jest Configuration #111

gregberge opened this issue Aug 16, 2018 · 3 comments

Comments

@gregberge
Copy link
Member

Now that jestjs/jest#5957 is merged and release, we can drop jest-puppeteer.config.js and use the Jest configuration.

We have to use testEnvironmentOptions and read configuration from this.

jest-puppeteer.config.js support will be deprecated and removed in the next major version.

@gregberge
Copy link
Member Author

It is actually not ready because as mentioned in jestjs/jest#5957 (comment), it is not possible to access testEnvironmentOptions in globalConfig.

@lukaszfiszer
Copy link
Contributor

lukaszfiszer commented Mar 27, 2019

Other projects use global for plugin-related config. Example: https://kulshekhar.github.io/ts-jest/user/config/#ts-jest-options jest-puppeteer could easily use this pattern too. What do you think @neoziro ?

@gregberge
Copy link
Member Author

Hello @lukaszfiszer, unfortunately globals are not accessible in globalConfig, see https://github.com/facebook/jest/blob/master/packages/jest-config/src/index.ts#L104. So we are still stuck with jest-puppeteer.config.js...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants