Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is cut on Android after upgrade to Expo SDK 33 and react 16.8.3 #76

Open
fimkap opened this issue Oct 22, 2019 · 4 comments
Open

Comments

@fimkap
Copy link

fimkap commented Oct 22, 2019

We noticed that after upgrade to Expo SDK 33 and react 16.8.3 under some conditions the text is cut at the end of paragraphs. We work with Hebrew (RTL).
It happens only on Android with larger screens. It looks like wrong calculation of internal size of a view based on the text. Playing with padding or margins in styles will not fix it. The simple-markdown used from react-native-markdown-view, we tried to change to another markdown package but it has the same issue.
What can be the reason for that and how it can be fixed?

@ariabuckles
Copy link
Owner

Hi fimkap,

This sounds like it's likely a react-native bug rather than a markdown bug, especially if this repro'd with a different package (although I'm interested in which package: if it's another simple-markdown based react-native package, it could be some awkward interaction between this project and react-native).

If you have a small project I could look at that reproduces this issue in an android simulator I'll look at it, although I'm not sure how much help I'll be able to be.

@fimkap
Copy link
Author

fimkap commented Nov 4, 2019

Hi,
I'll prepare a small project so you can take a look. I think another project was react-native-markdown-renderer. Thanks.

@fimkap
Copy link
Author

fimkap commented Nov 4, 2019

@ariabuckles Here's the project:
https://github.com/fimkap/markdown-cutoff
you can run it in Android emulator taking a bigger model like Pixel 3 then you'll see the issue

@fimkap
Copy link
Author

fimkap commented Nov 4, 2019

the screenshot
Screen Shot 2019-11-04 at 17 38 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants