Feat(eos_designs): Exclude l3_edge neighbors from peer_group #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erlay" is set to False and the protocol is ebgp.
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4491
# Activate the virtual environment
source test-avd-pr-4491/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/nathanmusser/avd.git@issue4379_p2p_links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/nathanmusser/avd.git#/ansible_collections/arista/avd/,issue4379_p2p_links --force
# Optional: Install AVD examples
cd test-avd-pr-4491
ansible-playbook arista.avd.install_examples |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When
routing_protocolis set toebgpandinclude_in_underlay_protocolis set tofalsefor anl3_edgelink, previously it was not rendered in BGP. It is now rendered into BGP without using the default underlay peer group.Related Issue(s)
Partially fixes #4379
Component(s) name
arista.avd.eos_designsProposed changes
Only render the peer group if
include_in_underlay_protocolis set totrue.How to test
Using the dual-dc-l3ls example topology you can modify the
l3_edgeinclude_in_underlay_protocolandrouting_protocolvalues in theFABRIC.ymlgroup_var.Checklist
User Checklist
Repository Checklist
Additional
I can add tests for this to molecule. I'm not sure if what the scope of the molecule tests are for the AVD project, and if we want every edge case covered or not. Additionally, while this behavior feels intuitive to me, I can explicitly add an example to the documentation, but documenting an edge case like this could be considered clutter so I didn't add anything yet.