Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression completions require quickSuggestions.string to be set to on #1056

Closed
ssalbdivad opened this issue Jul 21, 2024 · 3 comments
Closed

Comments

@ssalbdivad
Copy link
Member

For now, without the ArkDark extension, you will not completions for definigions like "string | num" unless you explicitly opt into the following setting in VSCode:

	"editor.quickSuggestions": {
		"strings": "on"
	}

The extension enables that for you, but users should not have to opt into anything to get the suggestions TS has inferred.

I've opened an issue on VSCode but am tracking it here as well in case anyone runs into this in the meantime:

microsoft/vscode#222583

@ssalbdivad
Copy link
Member Author

The team is not interested in revisiting this behavior so I'm closing this for now

microsoft/vscode#222583

@Dimava
Copy link
Contributor

Dimava commented Sep 25, 2024

Is this even documented somewhere?

edit: I see it's https://arktype.io/intro/setup/#settings

@ssalbdivad
Copy link
Member Author

It's VSCode who needs to up their documentation game in this case.

IMO if a completion is coming directly from TS, it should never be ignored by default regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (merged or closed)
Development

No branches or pull requests

2 participants