Override golang 1.14.4 and associated bbclasses, no folder changes necessary #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x85446
requested review from
whygoyal,
costanic,
kylestein-arm and
johnmichaelwelsh
|
Confirmed: Since we don't have CI/CD on this, I can confirm golang 14.4 ended up on the build. Job #30, Artifact 117
|
whygoyal
reviewed
Jul 18, 2020
|
@x85446 Apart from above comment, it LGTM. If we have used any reference to bring in these files, it will be good to mention it in the PR. |
Great, I have dropped the file and referenced the yocto Sha in the PR. golang 1.14.4 recipe and associated bbclasses is taken from the master branch of yocto at this point in time: https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ca701cb92dcf186664d9b1f82c679e4f9cc388ec |
whygoyal
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang 1.14.4 recipe and associated bbclasses is taken from the master branch of yocto at this point in time: https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ca701cb92dcf186664d9b1f82c679e4f9cc388ec