Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasm compiled sqlite when building without cgo #769

Closed
maruel opened this issue Sep 23, 2024 · 1 comment
Closed

Use wasm compiled sqlite when building without cgo #769

maruel opened this issue Sep 23, 2024 · 1 comment

Comments

@maruel
Copy link

maruel commented Sep 23, 2024

What about leveraging https://github.com/ncruces/go-sqlite3/ when ``//go:build !cgo` ?

https://github.com/cvilsmeier/go-sqlite-bench shows that while it's significantly slower than github.com/mattn/go-sqlite3, it's still bearable (yellow vs brown) and would simplify life for some use case, like building and testing on non-linux.

Coupled with issue #767, this would make the package reusable and easy to go install.

@arp242
Copy link
Owner

arp242 commented Sep 25, 2024

I would prefer to have a single code path, instead of two. Requiring a C compiler is a bit of a pain, I agree, but not enough of a pain to start shipping a separate version of SQLite.

Even on macOS or Windows it's not that big of a deal. (aside: the reason the last release doesn't have binaries for them is simply because my laptop ran out of disk space for the required VMs 😅 That problem has since been resolved by a new laptop).

@arp242 arp242 closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants