Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableOnClickOutside doesn't seem to do anything #402

Closed
poohsen opened this issue Aug 15, 2017 · 2 comments
Closed

disableOnClickOutside doesn't seem to do anything #402

poohsen opened this issue Aug 15, 2017 · 2 comments
Labels

Comments

@poohsen
Copy link

poohsen commented Aug 15, 2017

I'm Submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

render the following:

<Datetime
   disableOnClickOutside={true}
 />

Expected Results

When clicking outside of the datepicker I expect nothing to happen, i.e. the widget to stay open.

Actual Results

The widget closes. The behaviour is the same when disableOnClickOutside={true} is changed to disableOnClickOutside={false}

Other Information (e.g. stacktraces, related issues, suggestions how to fix)

reproduced in react-datetime version: 2.8.10 and 2.9
I'm using create-react-app and running npm start. I tried the latest Chrome and FF.

@simeg
Copy link
Collaborator

simeg commented Feb 7, 2018

I can't reproduce this. Could you provide a codepen that displays this error? You can use this one which has the component set up.

@simeg
Copy link
Collaborator

simeg commented Feb 8, 2018

Fixed in #405.

@simeg simeg closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants