Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement native texture support for BGRA textures on Windows, Linux. #29

Open
OptrixAU opened this issue Sep 2, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@OptrixAU
Copy link
Contributor

OptrixAU commented Sep 2, 2019

While it's ALWAYS crashed the iOS version, I've found that Native GL Texturing is causing crashes in the Android build now.

I've noticed that performance seems quite a bit better without the option anyway, so Native Texturing seems a little less necessary right now. Still, since it's an available option, I thought it'd be best to check.

@philip-lamb
Copy link
Member

Native texturing is not supported in arunityx at present. The trade-off is that native texturing required the video to be captured as 32-bit BGRA on the native side, and it still had to be converted to generate a luma-only version for the tracking. It was found to be more generally more efficient to capture in YUV422 and only convert to BGRA when Unity needed a frame, at the expense of keeping an additional frame buffer around. We could add it back in if it was still of interest.

@OptrixAU
Copy link
Contributor Author

OptrixAU commented Sep 2, 2019

Hmm...I found that performance is much better, so I'm currently not particularly upset it's gone. Unfortunately it's just been causing crashes in my application since the upgrade from v5 to X.

Perhaps the proper resolution to this bug is simply to remove the option from the Editor for now, force it to 'false' in code, and re-introduce it if required in the future?

Or at least force the value to 'false' during startup on iOS and Android platforms, since it seems to work OK in Windows?

@philip-lamb philip-lamb self-assigned this Mar 16, 2023
@philip-lamb philip-lamb added the enhancement New feature or request label Mar 16, 2023
@philip-lamb philip-lamb changed the title Native GL Texturing Crashing on Android Re-implement native texture support for BGRA textures on Windows, Linux. Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants