-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafito Docker broken? #27
Comments
Yes, that solved it.
That gives: (Haven't yet pulled Grafito / Arturo in there too), i assume its easier to add this at your end and push it again to dockerhub? |
That's awesome! 🚀 The truth is I had left Grafito for a while (until different things had made some progress in Arturo itself) and I got back to it some 3 months ago. It should - mostly - be working, although I admit the margin for improvements is always... ample. Ah... and why I'm saying all this? Because when "I got back to it", I completely forgot there was a Docker container as well! haha Since you spotted it, you are absolutely welcome to make a PR yourself if you want, and I will happily merge it (and then update the whole thing @ DockerHub). If not, I'll do it myself obviously. 😉 |
i'm not too familiar yet with a Dockerfile integration / Dockerhub uploading, as i mostly just dive in the docker commandline and save the image from there. But that's not good practice => so this is a good opportunity to get to learn it. => so deal! The caveat: needs to be quality-checked after! |
Don't worry about it! I'm not a Docker guru myself either - far from it actually! :) The main Dockerfile is here: https://github.com/arturo-lang/grafito/blob/main/Dockerfile. I think all you have to do is add the fix there... I think lol. Plus, you'll get the contribution credit you deserve! 😉 Regarding DockerHub, I'll take care of it. |
Ok, this part is tackled at least :-) => will make a fork and PR.
But I am(/we are) not out of the woods just yet, |
I'll have to test it myself as well and we'll see. Sure thing is there were issues with the last official release (Arturo's I mean)... which have been fixed in the meantime. So, the safest bet to see what works and what doesn't would be to use the latest Arturo version (@ master). As far as I remember, Docker-aside, the two main branches - Arturo and Grafito - should be working together fine right now (at last!). But, let's see, let's see... 😄 |
We shall! 👍 Impressive work on both, either way. this is just a minor wrinkle that will be smoothed out (soon). |
Could it be as simple as a missing bracket? If i paste grafito.art in arturo (with trailing spaces), i get a missing ] error. |
😄 Well... I guess the nature of the 2 projects (especially Arturo) is such that the "work in progress" stage is probably meant to remain there forever (and ever... lol). That being said, I confess I already use Arturo in totally production-level code and so far I've had no real issues. Regarding Grafito, well, that was more like a (very) daring try at using Arturo for something practical - and combining my newly-discovered interest for graphs and graph databases (long story short: I played with Neo4J, loved it, then decided to load it up in a DigitalOcean droplet, realized that thing needed a... super-computer to say the least, and then I followed my normal way of thinking: why not try doing it from scratch myself?! haha) P.S. You'll make me get back to Grafito seriously (again I mean!). And that's great! (if it weren't for some non-open-source related stuff I'm working on currently, I'd have more time, but what can I do about it...) |
Are you using the latest master-branch version of Arturo? (I'm asking so that I know what to test with... 😉 ) |
yes., using version v/0.9.83 b/889 for testing (own build on WSL2). got the feeling it there is something weird with the brackets in graph. should the helperfunctions be sub-functions of this block? |
Hmm... 🤔 I've just tried the A few notes:
This is what I'm looking at right now: P.S. If you have something concrete you want me to try out, please let me know. For more... Windows-related questions, I think our Discord channel would be a better place for this type of issues, since there are far more knowledgeable people there (and rather active!) that could possibly address them! 😉 |
@drkameleon: you wrote: "That being said, you're more than welcome to post all issues you come across, related to... anything."
=>Therefore ;-) :
When i run "docker run -it arturolang/grafito" from windows 11 pro & docker commandline <docker run -it arturolang/grafito>, the container is fetched correctly and built, but when it starts grafito, i get the following response (right after the Grafito-logo):
`
Possible cause:
Seems to me it is not assigning the engine field in the Versions dict correctly?
i assume the sqlite3 --version returns something faulty within the docker?
and indeed, from within arturo in the docker, i get this response:
$> execute "sqlite3 --version"
=> /bin/sh: sqlite3: not found
Or extended:
$> to :version first split.by:" " execute "sqlite3 --version"
The text was updated successfully, but these errors were encountered: