Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform argument #1018

Closed
aloctavodia opened this issue Jan 21, 2020 · 8 comments · Fixed by #1036
Closed

Add transform argument #1018

aloctavodia opened this issue Jan 21, 2020 · 8 comments · Fixed by #1036
Labels

Comments

@aloctavodia
Copy link
Contributor

A transform argument will allow users to pass a function that will be applied to one or more variables. This is related to pymc-devs/pymc#3420 and pymc-devs/pymc#3626

@amukh18
Copy link
Contributor

amukh18 commented Jan 21, 2020

I would like to work on this issue

@amukh18
Copy link
Contributor

amukh18 commented Jan 28, 2020

@aloctavodia Could you please give me a brief description of what "transformation of an MCMC sample" means?

@amukh18
Copy link
Contributor

amukh18 commented Jan 28, 2020

@aloctavodia I would also be grateful if you could link me to some resources that may give me an idea of what the transform function should do.

@ahartikainen
Copy link
Contributor

Like np.log or np.exp done for the samples. So basically any transformation which might eat one more "variables" and outputs a new variable / variables.

@aloctavodia
Copy link
Contributor Author

@amukh18 check this from an early version of arviz

@amukh18
Copy link
Contributor

amukh18 commented Jan 29, 2020

@ahartikainen I understand. Thank you!

@amukh18
Copy link
Contributor

amukh18 commented Jan 29, 2020

@aloctavodia So for the new argument would I need to create something like a new identity_transform function?

@ahartikainen
Copy link
Contributor

I think it could be None by default (==identity_transform) and not do any transformations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants