Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of from_pymc3 outside the model context #1470

Closed
AlexAndorra opened this issue Dec 22, 2020 · 1 comment
Closed

Deprecate the use of from_pymc3 outside the model context #1470

AlexAndorra opened this issue Dec 22, 2020 · 1 comment

Comments

@AlexAndorra
Copy link
Contributor

AlexAndorra commented Dec 22, 2020

When people give PyMC's MultiTrace objects to ArviZ functions outside the model context, this raises a FutureWarning because it calls az.from_pymc3 under the hood, which is supposed to stop working without a model context.

As this warning has been there for a while now, we should actually go ahead and deprecate this possibility, especially as PyMC is going to switch to returning InferenceData by default in 4.0.0.

Feel free to comment if you want to take on this issue 🖖

@OriolAbril
Copy link
Member

Closing this as we moved the converter to pymc3 codebase and the model context is already required in the v4 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants