Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing arviz breaks pymc3 installation #594

Closed
lwahedi opened this issue Feb 20, 2019 · 6 comments · Fixed by #596
Closed

Installing arviz breaks pymc3 installation #594

lwahedi opened this issue Feb 20, 2019 · 6 comments · Fixed by #596

Comments

@lwahedi
Copy link

lwahedi commented Feb 20, 2019

Describe the bug
Installing Arviz breaks a pymc3 installation, which is unfortunate because they're built to be compatible. After installation, importing pymc3 throws the following error.

WARNING (theano.tensor.blas): Using NumPy C-API based implementation for BLAS functions.

The reason is because arviz installation requires numpy==1.15 rather than numpy>=1.15. If you have 1.16, it uninstalls it and re-installs 1.15. It's annoying to fix. I ended up having to scrap the whole virtual environment and start over.

To Reproduce
Install arviz if you have any version of numpy other than 1.15, then import pymc3.

Expected behavior
Do not force downgrade of numpy.

@ColCarroll
Copy link
Member

Thanks for the report! I can confirm that in the pypi released version, the requirements are:

matplotlib>=3.0
numpy==1.15
scipy
pandas
xarray
netcdf4

(this fixed a bug that used to exist in numpy)

The best solution would be cutting a release with only that removed, but the easiest solution would be cutting a new release off master asap.

@lwahedi
Copy link
Author

lwahedi commented Feb 21, 2019

So does this mean that arviz will not work with either older or newer versions of numpy? That's good to know, because my workaround was just to install it either first, or without dependencies and then install the rest of the dependencies individually. But it may mean that if you plan to use arviz you should fix your numpy back to 1.15 in your docker/virtualenv/etc/.
Might at least be worth a note in the documentation section on using arviz with pymc3 traces.

@canyon289
Copy link
Member

@lwahedi Apologies on this issue. It's definitely annoying

To answer your question, It will work with newer versions of numpy, this was a short term fix that we applied due to a numpy bug a couple months ago that was not supposed to make it into production.

We're going to cut a pypi release on Saturday to unpin numpy version (and introduce more features!)

For now the best option would be to install from github master.

Sorry for all the trouble, and we really appreciate you creating this issue

@canyon289
Copy link
Member

@lwahedi We released version 0.3.3 of arviz. On my local machine the release fixed the numpy pinning issue.

Would you want to verify that it works locally for you as well?

image

@canyon289
Copy link
Member

I believe this issue is fixed. Closing for now

@lwahedi
Copy link
Author

lwahedi commented Mar 7, 2019

Sorry for disappearing, was traveling. But yes, it all works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants