From 24595710fd84d65600cb5f1787bb645cdf024971 Mon Sep 17 00:00:00 2001 From: Oriol Brufau Date: Thu, 3 Feb 2022 23:57:31 +0100 Subject: [PATCH] Remove the concept of "expressly inert" It seems to be a remnant of control groups, which were removed in 90a60b2a0dc740b8b0093b07ca0a41e70ba8d83a. All uses are replaced with the concept of "inert". Also clean up "When a key event is to be routed in a top-level browsing context", which seems to have remnants of when control groups allowed inert elements inside an inert dialog to be focusable. Fixes #7564. --- source | 37 ++++++++++++------------------------- 1 file changed, 12 insertions(+), 25 deletions(-) diff --git a/source b/source index 1bb2e051ce5..93ce8f65d58 100644 --- a/source +++ b/source @@ -74904,10 +74904,6 @@ END:VCARD nested browsing context's active document, and all nodes in that Document, must be marked as inert.

-

An element - is expressly inert if it is inert and its node document is - not inert.

-

A Document document is blocked by a modal dialog subject if subject is the topmost dialog element in document's top layer. While document is so blocked, every node @@ -75245,7 +75241,7 @@ END:VCARD

  • the element is not actually disabled;
    • -
  • the element is not expressly inert;
    • +
  • the element is not inert;
  • the element is either being rendered or being used as relevant canvas fallback content.
    • @@ -75262,8 +75258,7 @@ END:VCARD The shapes of area elements in an image map associated with an - img element that is being rendered and is not expressly - inert. + img element that is being rendered and is not inert. The img element. @@ -75283,8 +75278,7 @@ END:VCARD The user-agent provided subwidgets of elements that are being rendered and are not - actually disabled or expressly - inert. + actually disabled or inert. The element for which the focusable area is a subwidget. @@ -75299,9 +75293,9 @@ END:VCARD The scrollable regions of elements that are being rendered and are not - expressly inert. + inert. The element for which the box that the scrollable region scrolls was created. @@ -76034,8 +76028,8 @@ END:VCARD

    Focus fixup rule: When the designated focused area of the document is removed from that Document in some way (e.g. it stops being a focusable area, it is removed from the DOM, it becomes - expressly inert, etc.), designate the Document's viewport - to be the new focused area of the document.

    + inert, etc.), designate the Document's viewport to be the + new focused area of the document.

    For example, this might happen because an element is removed from its Document, or has a hidden attribute added. It might @@ -76168,11 +76162,10 @@ END:VCARD

  • Assert: target area is not null, since key events are only routed to top-level browsing contexts that have system focus.

    • + data-x="tlbc system focus">system focus. Therefore, target area is a + focusable area.

    -

  • If target area is a focusable area, let target - node be target area's DOM anchor. Otherwise, target area is a dialog; let target node be - target area.

    • +

  • Let target node be target area's DOM anchor.

  • If target node is a Document that has a It is possible for the currently focused area of a top-level browsing - context to be inert, for example if a modal dialog is shown, and then that dialog - element is made inert. It is likely to be the result of a logic error in the - application, though.

    -

    1. Let canHandle be the result of dispatching the key event at target @@ -128193,6 +128179,7 @@ INSERT INTERFACES HERE Olli Pettay, Ondřej Žára, Ori Avtalion, + Oriol Brufau, oSand, Pablo Flouret, Patrick Dark,