Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting boost temp sometimes errors #4

Closed
msp1974 opened this issue Dec 23, 2019 · 5 comments
Closed

Setting boost temp sometimes errors #4

msp1974 opened this issue Dec 23, 2019 · 5 comments

Comments

@msp1974
Copy link
Collaborator

msp1974 commented Dec 23, 2019

I have seen a situation whereby setting the boost temp when calling setRoomMode causes an error from the hub that it is expecting an integer.

I think this is caused by the fact that passing a float value (ie 21.5) to the method maintains a float when passing to the hub.

Line
temp=boost_temp*10

needs to be
temp=int(boost_temp*10)

to ensure this cannot happen

Thx Mark

@asantaga
Copy link
Owner

asantaga commented Jan 8, 2020

Hey Mark, I think I fixed this bug earlier on, which version of HA are you using?
(still not got around to fixing my server :-( , xmas lag...)

@msp1974
Copy link
Collaborator Author

msp1974 commented Jan 9, 2020

I am running 103.4 with wiser component 1.7.1. I can send you a PR but think just need to sent to an integer value when we multiply boost temp by 10. Think you have fixed this in the setTemperature method but not in the setRoomMode method.

@msp1974
Copy link
Collaborator Author

msp1974 commented Jan 9, 2020

Sorry i was probably remembering a previous version where you were removing the decimal point instead of multiplying by 10. It is true that i cannot recreate this issue right now but i think we maybe should do the integer conversion as suggested to ensure we cannot pass a non integer value to the wiser hub.

asantaga pushed a commit that referenced this issue Jan 12, 2020
Fixed: Error calling temp range check
@asantaga
Copy link
Owner

Mark,. this issue is fixed with your PR right?

@msp1974
Copy link
Collaborator Author

msp1974 commented Jan 12, 2020

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants