Simpler image right alignment #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 When considering how to implement styles, don't rule out flexbox for alignment. It's supported perfectly across browsers and it it's extremely powerful. In particular, it's very good at self-alignment of items. |
obilodeau
added a commit
to obilodeau/asciidoctor-reveal.js
that referenced
this pull request
Oct 30, 2018
Related to the just-added asciidoctor#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "right" role can be applied on all divs under revealjs CSS class namespace. If you think this is a bad idea, say so. This is our first attempt at overriding CSS from reveal.js.
Initial attempt is promising, we could backport a lot of AsciiDoc's features like tables and more. Lots of issues already open for these.
That said, I would have preferred a pure
.cssfile include (so that syntax highlighting and IDE would have played along better) but I couldn't make it work.PR to fix #197.
Note to reviewers: there is more test code in there than actual code. I'll merge it relatively soonish so I can get my Hacktoberfest t-shirt 😉