background-video doesn't honor imagesdir attribute like it should #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating what I thought was a problem with Asciidoctor, I realize that we are badly loading background-video local files.
Asciidoctor uses the
media_uri
method to lookup video files and we used it in the video template but forbackground-video
this wasn't used.This PR fixes that behavior.
Now, is this a backward-incompatible fix? It could break existing decks that relied on the wrong behavior. However, it was obviously broken and didn't follow what an Asciidoctor/AsciiDoc user would expect. I'm open to make this change part of a feature release but I would find it intense to bump a major version because of this. Guidance needed here.
Note
background-video
is already correctly implementedThe first commit just exhibit the bug (I want to see it in travis), I have a local fix read to be pushedfix pushed