Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade font-awesome to 5.13.0 #363

Closed
mrcasablr opened this issue Mar 29, 2020 · 2 comments · Fixed by #392
Closed

Upgrade font-awesome to 5.13.0 #363

mrcasablr opened this issue Mar 29, 2020 · 2 comments · Fixed by #392
Labels
🍩 improvement 👋 help wanted
Milestone
4.1.0

Comments

@mrcasablr
Copy link

I'm sure some of us could use the covid-19 fonts from 5.13.0

https://fontawesome.com/changelog/latest
@obilodeau
Copy link
Member

Great idea. I wasn't aware of them.

If you are in a rush, you can either patch this plugin or negate the iconfont-remote attribute. However, I've never tried that last option personally, from my casual reading of the code, it should work.

In any case, I'm scheduling an update but I'm not working on asciidoctor-reveal.js right now. Other time-sensitive volunteer activities going on.

@obilodeau obilodeau added this to the 4.1.0 milestone May 1, 2020
@ggrossetie
Copy link
Member

Contributions are welcome, feel free to submit a pull request to update the version in templates/document.html.slim as mentioned by Olivier.

@ggrossetie ggrossetie mentioned this issue Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 improvement 👋 help wanted
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Upgrade Font Awesome to 5.15.1 ggrossetie/asciidoctor-reveal.js
3 participants
@ggrossetie @obilodeau @mrcasablr