-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractConverter
in typings should be made generic
#1697
Comments
That's a good point. Are you willing to open a pull request to update the type definition? |
@ggrossetie I gave it a try to contribute. When reading packages/core/types/README.adoc, it looks as if you have to run the generation command within the
There is also the |
The current 3.0.0 prerelease code uses
string
as the return type for theAbstractConverter.convert
method:asciidoctor.js/packages/core/types/index.d.ts
Lines 3119 to 3132 in a8c4c96
When I inquired about the return type on the Zulip forums, I received the answer that
I'm not an experienced Javascript developer, so I rely a lot on the type definitions which come with a package. As I discussed on this topic, I want to return a React component, but this conflicts with the current method return type.
Would it still be possible to make the definition of the
AbstractConverter.convert
method generic before the 3.0.0 final release?The text was updated successfully, but these errors were encountered: