Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License file not distributed in package #37

Open
scopatz opened this issue Mar 21, 2019 · 5 comments
Open

License file not distributed in package #37

scopatz opened this issue Mar 21, 2019 · 5 comments

Comments

@scopatz
Copy link

scopatz commented Mar 21, 2019

If you download the source tarball from PyPI, the license is not present

@adisakshya
Copy link
Contributor

If you download the source tarball from PyPI, the license is not present

Actually if you see the MANIFEST.in file it includes "COPYING" and "README.markdown" here "COPYING" is the License file that is in the root directory. Hope it helps.

@scopatz
Copy link
Author

scopatz commented May 13, 2019

I don't think that is working properly then. If you go to here, and download the package, and then unzip it:

scopatz@artemis ~/downloads/t $ tar xvf ../exrex-0.10.5.tar.gz
exrex-0.10.5/
exrex-0.10.5/PKG-INFO
exrex-0.10.5/setup.py
exrex-0.10.5/exrex.egg-info/
exrex-0.10.5/exrex.egg-info/PKG-INFO
exrex-0.10.5/exrex.egg-info/entry_points.txt
exrex-0.10.5/exrex.egg-info/top_level.txt
exrex-0.10.5/exrex.egg-info/SOURCES.txt
exrex-0.10.5/exrex.egg-info/dependency_links.txt
exrex-0.10.5/exrex.py
exrex-0.10.5/setup.cfg

you can see that the COPYING file is not present

@adisakshya
Copy link
Contributor

adisakshya commented May 13, 2019

Yes this is not working properly.
I have improved setup.py file in PULL_REQUEST_#39, and
I have tested modules on TestPyPi and there everything is working fine
Use this link to download source tarball(SHA256): here or link-TestPyPi-files

exrex-0.10.13/
exrex-0.10.13/COPYING
exrex-0.10.13/exrex.py
exrex-0.10.13/MANIFEST.in
exrex-0.10.13/PKG-INFO
exrex-0.10.13/README.md
exrex-0.10.13/setup.cfg
exrex-0.10.13/setup.py
exrex-0.10.13/exrex.egg-info/
exrex-0.10.13/exrex.egg-info/PKG-INFO
exrex-0.10.13/exrex.egg-info/entry_points.txt
exrex-0.10.13/exrex.egg-info/top_level.txt
exrex-0.10.13/exrex.egg-info/SOURCES.txt
exrex-0.10.13/exrex.egg-info/dependency_links.txt

Now you can see that COPYING is included.

@scopatz
Copy link
Author

scopatz commented May 13, 2019

Yes, I can confirm that it is fixed in testing.

@adisakshya
Copy link
Contributor

Yeah ! Fix will be live once pull_request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants