added extraction of title from schema to show as a comment in info() #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
pllim
reviewed
May 25, 2022
| @@ -53,7 +53,7 @@ docs = | |||
| tests = | |||
| # Necessary for Windows until https://github.com/pytest-dev/pytest/issues/9765 | |||
| # is resolved: | |||
| pytest!=7.1.0, !=7.1.1;sys_platform=="win32" | |||
| pytest!=7.1.0, !=7.1.1, !=7.1.2;sys_platform=="win32" | |||
There was a problem hiding this comment.
I am trying to track a failure in Jdaviz and I am suspecting it has something to do with asdf. Why did you pin a !=7.1.2 here?
There was a problem hiding this comment.
Oh hmm, this only is for Windows... my failure is on Linux.
There was a problem hiding this comment.
Does this error ring any bell to you?
2022-05-25T20:01:04.0755535Z INTERNALERROR> Traceback (most recent call last):
2022-05-25T20:01:04.0756248Z INTERNALERROR> File "<frozen importlib._bootstrap>", line 939, in _find_spec
2022-05-25T20:01:04.0756783Z INTERNALERROR> AttributeError: '_SixMetaPathImporter' object has no attribute 'find_spec'
There was a problem hiding this comment.
Not sure. It looks like it is coming from one of the plugins and you ship with your own pytest plugin, right? I'll dig more.
There was a problem hiding this comment.
Sorry for the noise. It's not ASDF. Something happened in the Python 3.10 that shipped with Actions runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that due to how the extension manager works, for the test file this required adding an option to info to force reloading of the extension manager so that the test extensions would be seen. There may be a better way to handle this. It should handle attributes that use patternProperty, oneOf, allOf, or anyOf constructs. This addresses issue #1137.