Unpin jsonschema, fix default validation #1203
Conversation
|
Unfortunately, we cannot unpin |
|
I opened PR: braingram#1 on your branch in your fix for the |
|
Also your history is messed up. As a general rule, we do not accept PRs with merge commits inside them like 48527ec (note that merge commits of a PRs onto your branch are fine). This is so we can have a clean history. This is typically caused by trying to use the "Update branch" button on github. Instead, you should do a |
braingram
force-pushed
the
feature/jsonschema_4.10
branch
2 times, most recently
from
d444815
to
5ab2193
Compare
|
Thanks! I rebased and accepted your PR braingram#1. Thanks also for pointing out #1185 Am I understanding the CI logs right in thinking the errors are in tests for asdf-standard? I have not run those locally and will do so. |
|
Ran pytest locally with jsonschema==4.0.1. All asdf tests passed. |
braingram
force-pushed
the
feature/jsonschema_4.10
branch
from
b77e87a
to
e387ea7
Compare
|
It is unfortunate that the devdeps jobs are not allowing an install with the development dependency. It will take more effort to resolve this... |
|
A simple approach is, we merge #1185 with the tests this fixes marked as |
|
@braingram can you rebase this now that #1185 is merged and remove the two |
braingram
force-pushed
the
feature/jsonschema_4.10
branch
from
e387ea7
to
d419b48
Compare
Add custom default validator to 'applicable_validators' argument to jsonschema.validators.create Tested locally with jsonschema 4.16 update changelog [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
Co-authored-by: William Jamieson <[email protected]>
braingram
force-pushed
the
feature/jsonschema_4.10
branch
from
d419b48
to
ee7eed6
Compare
https://build.opensuse.org/request/show/1030520 by user bnavigator + dimstar_suse - Update to 2.13.0 * The ASDF Standard is at v1.6.0 * Add ability to pull information from schema about asdf file data, using ~asdf.AsdfFile.schema_info method. [#1167] - Release 2.12.1 * Overhaul of the ASDF documentation to make it more consistent and readable. [#1142, #1152] * Update deprecated instances of abstractproperty to abstractmethod [#1148] * Move build configuration into pyproject.toml [#1149, #1155] * Pin jsonschema to below 4.10.0. [#1171] - Release 2.12.0 * Added ability to display title as a comment in using the info() functionality. [#1138] * Add ability to set asdf-standard version for schema example items. [#1143] - Add asdf-pr1185+pr1203-fix-jsonschema.patch * gh#asdf-format/asdf#1185, gh#asdf-format/asdf#1203 - Add asdf-pr1214-inst
* gnu/packages/astronomy.scm (python-gwcs): Fix build and update to 0.18.2. [build-system]: Use pyproject-build-system. [arguments]: Remove redundant. [native-inputs]: Use python-jsonschema-next over python-jsonschema to fix tests failing to run due to python-asdf issue with low version of jsonschema, see asdf-format/asdf#1203. Signed-off-by: Christopher Baines <[email protected]>
Add custom default validator to 'applicable_validators' argument to jsonschema.validators.create
Tested locally with jsonschema 4.16
This is work towards fixing #1172
One test is still failing locally (a doctest in docs/asdf/config.rst) but I wanted to trigger the CI and discuss the changes so far.
closes #1177