Deprecate/assert extension correctness #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
deprecate/assert_extension_correctness
branch
from
7300c36
to
f4954ab
Compare
15 tasks
WilliamJamieson
force-pushed
the
deprecate/assert_extension_correctness
branch
from
f4954ab
to
db7463a
Compare
WilliamJamieson
approved these changes
Feb 21, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/asdf
that referenced
this pull request
Feb 21, 2023
WilliamJamieson
pushed a commit
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1362 (comment)
asdf.tests.helpers.assert_extension_correctness is only used for the legacy deprecated extension api and should be deprecated.