remove deprecated AsdfFile.open, asdf.open, write_to, update kwargs, #1592
Conversation
braingram
force-pushed
the
asdf_open_args
branch
from
aff3b1d
to
f17aaf4
Compare
braingram
changed the title
| ) | ||
| except Exception: | ||
| if close_on_fail: | ||
| generic_file.close() | ||
| raise | ||
|
|
||
| @classmethod |
asdf/_tests/test_api.py
Outdated
There was a problem hiding this comment.
There is a method in this module called test_auto_inline that uses the auto_inline argument, does that test need to go?
There was a problem hiding this comment.
Yes! Thanks for the catch.
Oddly, this test was never being run :-| It appears that using the exception class in the pytest.mark.filterwarnings decorator causes the test to be skipped (because pytest decorates the exception with the mark then makes the exception with the function as an argument).
I removed the test and it doesn't appear that there is any other use of filterwarnings that provides the exception class as the argument. Thanks again for the catch.
braingram
force-pushed
the
asdf_open_args
branch
from
285e2f6
to
56db403
Compare
|
The dkist error looks unrelated and appears to be something with astropy trying to download files during test collection: |
remove AsdfFile.open mention in docstring
this test was previously never run because of the odd behavior of pytest when filterwarnings is provided an exception class (instead of a string). This results in the exception class being decorated with the mark, then the function being provided as the first argument to the class (as the exception class is used as the decorator). Because the exception class does not start with "Test" the test is ignored during collection.
braingram
force-pushed
the
asdf_open_args
branch
from
56db403
to
2ea7c94
Compare
With the removal of the deprecated kwargs the
**kwargswere also expanded and documented to make it more explicit what arguments are supported.devdeps will fail due to pyyaml and cython3 incompatibility: yaml/pyyaml#601
stdatamodels downstream failure addressed in: #1594