Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add float16 support #1692

Merged
merged 3 commits into from
Mar 25, 2024
Merged

add float16 support #1692

merged 3 commits into from
Mar 25, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Nov 20, 2023

Description

This PR adds float16 support to asdf. As this requires changes to the ndarray schema (part of the asdf standard) this PR currently has asdf-standard installed via git from the source branch for: asdf-format/asdf-standard#411 EDIT: a new version of asdf-standard was released

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

Copy link
Contributor

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs that final dependency update

@braingram
Copy link
Contributor Author

Thanks! I will update this (and bring it out of draft) after asdf-standard is released.

@braingram
Copy link
Contributor Author

braingram commented Mar 9, 2024

Thanks @eslavich for the review. asdf-standard 1.1.0 (and 1.1.1) is out with the changes required for this PR. I bumped the required version (removing the dev requirement) and made a few minor docs fixes EDIT: moved these to #1770. If you have a chance would you give this another look?

@braingram braingram requested a review from eslavich March 9, 2024 18:23
@braingram
Copy link
Contributor Author

The asdf-transform-schemas failure is expected until asdf-astropy can be updated for the new manifest added in asdf-transform-schemas 0.5.0

@braingram braingram changed the title add float16 support (and dev asdf-standard dep) add float16 support Mar 10, 2024
@braingram braingram merged commit 48c5c57 into asdf-format:main Mar 25, 2024
34 checks passed
@braingram braingram deleted the f16 branch March 25, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants