Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate asdf.util.filepath_to_url #1735

Merged
merged 2 commits into from
May 7, 2024
Merged

deprecate asdf.util.filepath_to_url #1735

merged 2 commits into from
May 7, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Jan 17, 2024 •
edited
Loading

Description

This PR deprecates asdf.util.filepath_to_url. It is mostly used in asdf tests (there is no known downstream usage) and is easily replaced by pathlib.Path.as_uri which has the added benefit of supporting pathlib.Path inputs.

Fixes: #1717

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review January 17, 2024 19:39
@braingram braingram requested a review from a team as a code owner January 17, 2024 19:39
@braingram braingram marked this pull request as draft January 17, 2024 19:47
@braingram braingram marked this pull request as ready for review January 17, 2024 20:29
@braingram braingram added this to the 3.1.0 milestone Jan 23, 2024
@braingram braingram force-pushed the filepath_to_url branch 3 times, most recently from d046e96 to d236c52 Compare February 27, 2024 14:58
@braingram braingram modified the milestones: 3.1.0, 3.2.0 Feb 27, 2024
zacharyburnett
zacharyburnett approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a question about ~ and .expanduser()

asdf/generic_io.py Outdated Show resolved Hide resolved
pytest_asdf/plugin.py Outdated Show resolved Hide resolved
pytest_asdf/plugin.py Outdated Show resolved Hide resolved
@braingram braingram force-pushed the filepath_to_url branch 2 times, most recently from c7fd0b1 to d4cd81e Compare May 7, 2024 20:40
@braingram braingram merged commit d46fb6b into asdf-format:main May 7, 2024
48 checks passed
@braingram braingram deleted the filepath_to_url branch May 7, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

@eslavich eslavich Awaiting requested review from eslavich

Assignees
No one assigned
Labels
Downstream CI
Projects
None yet
Milestone
3.X
Development

Successfully merging this pull request may close these issues.

asdf.util.filepath_to_url does not accept Path instances
2 participants
@braingram @zacharyburnett