Force new blocks to be contiguous #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in asdf assumes a block will be a contiguous block of memory. But recent versions of numpy have used views more heavily and now there are cases when an object instantiated as a bock is not contiguous, which leads to errors when the block is used. The modified code calls numpy.ascontiguousarray to make sure the block memory is contiguous. This is a revised version of the branch, as several other irrelevant changes were put in the previous verion of the branch.
Testing makes it look like ascontiguousarray does not check this flag, so now the code does the check before calling it. Not doing this check can lead to having multiple copies of the same data which is a bad thing and leads to file growth on copying.
Rethinking the issues involved here made me change the if test to check if the block being copied is an ndarray. If not, it can't be non-contiguous, as that "feature" is only available for an ndarray.
|
Closing out an old issue first raised by a problem encountered by Phil. |
|
@bernie-simon I see the tests failed. Do you know how they failed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in asdf assumes a block will be a contiguous block of memory. But recent versions of numpy have used views more heavily and now there are cases when an object instantiated as a bock is not contiguous, which leads to errors when the block is used. The modified code calls numpy.ascontiguousarray to make sure the block memory is contiguous.
This is a revised version of the branch, as several other irrelevant changes were put in the previous version of the branch.