Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diff tool for ASDF files #286

Merged
merged 6 commits into from
Aug 4, 2017

Conversation

drdavella
Copy link
Contributor

@drdavella drdavella commented Jul 27, 2017

This resolves #211 and implements a diff tool that can be used for ASDF files. I don't have a ton of test cases so there may be missing features and/or buggy behavior on certain files.

@nden since this was your request maybe you can take it for a spin when you have a chance and let me know what you think.

@drdavella
Copy link
Contributor Author

This kind of feature doesn't lend itself very well to unit testing, but it might be good to give some thought to how it can be tested.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 91.777% when pulling f704aeb on drdavella:asdf-diff into fd5ea50 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 91.777% when pulling f704aeb on drdavella:asdf-diff into fd5ea50 on spacetelescope:master.

@nden
Copy link
Contributor

nden commented Aug 3, 2017

This is really useful when looking at different versions of reference files. 👍 for merging

@drdavella
Copy link
Contributor Author

Awesome! I think I should probably try to add some kind of tests first though since it drastically reduces overall test coverage...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.153% when pulling 474701e on drdavella:asdf-diff into 44b6a10 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.194% when pulling 26022af on drdavella:asdf-diff into 44b6a10 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 94.216% when pulling b77c8c9 on drdavella:asdf-diff into 44b6a10 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 94.393% when pulling 0f7df43 on drdavella:asdf-diff into 44b6a10 on spacetelescope:master.

@drdavella drdavella merged commit 6956b2b into asdf-format:master Aug 4, 2017
@drdavella drdavella deleted the asdf-diff branch August 4, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff tool for ASDF files
3 participants