Ensure when closing, to explicitly close data blocks #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to close out references to memory-mapped arrays that, in the current context, not associated with a file. The `Block._memmapped` is `False` but the `.data` is a memory-mapped array. WIP jwst #2282
|
Hi there @stscieisenhamer 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
|
A bit of test code can be found in @stscieisenhamer gist asdf_blocks.py. If run without this patch, the end result is 1 open file handle, which has no direct way of being closed. With the patch, no file handles are left. |
drdavella
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close out references to memory-mapped arrays that,
in the current context, not associated with a file. The
Block._memmappedis
Falsebut the.datais a memory-mapped array.WIP spacetelescope/jwst#2282