Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable validation/serialization of numpy scalar types #778

Merged
merged 4 commits into from
Apr 10, 2020

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented Apr 9, 2020

This PR enables validation and/or serialization of numpy.str_, numpy.bytes_, numpy.floating, and numpy.integer values. These values will now all validate against the relevant jsonschema types, and serialize to YAML primitives.

@eslavich eslavich added this to the 2.6.0 milestone Apr 9, 2020
@eslavich eslavich requested a review from nden April 9, 2020 19:01
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #778 into master will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   93.82%   93.83%           
=======================================
  Files          43       43           
  Lines        4908     4915    +7     
=======================================
+ Hits         4605     4612    +7     
  Misses        303      303           
Impacted Files Coverage Δ
asdf/schema.py 93.56% <50.00%> (+0.07%) ⬆️
asdf/yamlutil.py 97.36% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09672c8...b6bf646. Read the comment docs.

Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eslavich eslavich closed this Apr 10, 2020
@eslavich eslavich reopened this Apr 10, 2020
@eslavich
Copy link
Contributor Author

(oops, wrong button)

@eslavich eslavich merged commit 78e53bc into asdf-format:master Apr 10, 2020
@eslavich eslavich deleted the AL-274-serialize-np-string branch April 10, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants