Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated pytest initializer #789

Closed
eslavich opened this issue Apr 30, 2020 · 2 comments · Fixed by #799
Closed

Stop using deprecated pytest initializer #789

eslavich opened this issue Apr 30, 2020 · 2 comments · Fixed by #799
Milestone

Comments

@eslavich
Copy link
Contributor

This warning started appearing with pytest 5.4:

pytest.PytestDeprecationWarning: direct construction of AsdfSchemaFile has been deprecated, please use AsdfSchemaFile.from_parent

https://docs.pytest.org/en/latest/deprecations.html#node-construction-changed-to-node-from-parent has advice on how to continue to support multiple pytest versions.

@eslavich eslavich added this to the 2.6.1 milestone Apr 30, 2020
@pllim
Copy link
Contributor

pllim commented May 5, 2020

cc @bsipocz

@bsipocz
Copy link
Contributor

bsipocz commented May 5, 2020

yes, this is the one I see. If it comes up in CI, we should just add it to the ignore warnings list, I don't think this alone should trigger a version bump.

@eslavich eslavich modified the milestones: 2.6.1, 2.7.0 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants