Fix auto_inline when block is already set to inline #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 94.07% 94.18% +0.11%
==========================================
Files 42 42
Lines 5013 5005 -8
==========================================
- Hits 4716 4714 -2
+ Misses 297 291 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes auto_inline's behavior when a block is already set to inline, and the associated array exceeds the limit for inline representation. Previously the block would continue to be written inline, but with these changes it will change to "internal".
I'm also removing an unused internal method,
_should_inline, which is a remnant of the similar inline_threshold feature that was reverted.Resolves #599