Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsonschema 2.x support and update minimal dependencies #807

Merged

Conversation

eslavich
Copy link
Contributor

This PR drops support for jsonschema 2.x, in anticipation of needing 3.x for draft-07.

I also compared tox.ini, setup.cfg, and the documentation, and noticed a few discrepancies. I chose the highest minimum versions from among them and updated everything to match.

@eslavich eslavich added this to the 2.7.0 milestone May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #807 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   94.17%   94.26%   +0.09%     
==========================================
  Files          42       42              
  Lines        4979     4971       -8     
==========================================
- Hits         4689     4686       -3     
+ Misses        290      285       -5     
Impacted Files Coverage Δ
asdf/schema.py 96.36% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c73fc7...3c23e0c. Read the comment docs.

@eslavich eslavich requested a review from jdavies-st May 26, 2020 22:27
Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Always fun to delete lots of code.

@eslavich eslavich force-pushed the eslavich-remove-jsonschema-2-support branch from 43743ad to 3c23e0c Compare May 27, 2020 14:39
@eslavich eslavich merged commit ad141da into asdf-format:master May 27, 2020
@eslavich eslavich deleted the eslavich-remove-jsonschema-2-support branch May 27, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants