Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asdftool tags and asdftool extensions for new extension API #988

Merged
merged 2 commits into from
May 5, 2021
Merged

Update asdftool tags and asdftool extensions for new extension API #988

merged 2 commits into from
May 5, 2021

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented May 4, 2021 •
edited
Loading

Long term we may want to drop these, the Python API has plenty of options for getting at this information.

Resolves #959

@eslavich eslavich added this to the 2.8.0 milestone May 4, 2021
@eslavich eslavich requested a review from jdavies-st May 4, 2021 15:34
jdavies-st
jdavies-st approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

These tools are actually pretty useful, though if standard built-in python command line tools make this simple as well, then we should deprecate this, or implement them using those built-in tools.

@eslavich eslavich merged commit 7e8acee into asdf-format:master May 5, 2021
@eslavich eslavich deleted the AL-524-asdftool-new-extension-api branch May 5, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavies-st jdavies-st jdavies-st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

asdftool does not yet account for the new extension API
2 participants
@eslavich @jdavies-st