From dd1309bc5461178c0ad02a15ec340650a80c19a3 Mon Sep 17 00:00:00 2001 From: Jason Bedard Date: Mon, 27 Nov 2023 13:23:02 -0800 Subject: [PATCH] docs: add note about issue #58 --- docs/esbuild.md | 4 ++++ esbuild/private/esbuild.bzl | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/docs/esbuild.md b/docs/esbuild.md index ba9fdb5..6538d7c 100644 --- a/docs/esbuild.md +++ b/docs/esbuild.md @@ -17,6 +17,10 @@ Runs the esbuild bundler under Bazel For further information about esbuild, see https://esbuild.github.io/ +Note: esbuild currently follows symlinks and leaves the bazel sandbox, see https://github.com/aspect-build/rules_esbuild/issues/58 for potential issues and workarounds. + +For example, escaping the sandbox may require extra configuration such as overriding the default `resolveExtensions` to not load .ts[x] files that are pre-compiled by other rules. + **ATTRIBUTES** diff --git a/esbuild/private/esbuild.bzl b/esbuild/private/esbuild.bzl index ee5f35d..725ee50 100644 --- a/esbuild/private/esbuild.bzl +++ b/esbuild/private/esbuild.bzl @@ -433,5 +433,9 @@ esbuild_bundle = rule( Runs the esbuild bundler under Bazel For further information about esbuild, see https://esbuild.github.io/ + +Note: esbuild currently follows symlinks and leaves the bazel sandbox, see https://github.com/aspect-build/rules_esbuild/issues/58 for potential issues and workarounds. + +For example, escaping the sandbox may require extra configuration such as overriding the default `resolveExtensions` to not load .ts[x] files that are pre-compiled by other rules. """, )