Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Example usage that builds esbuild from go_binary rule and possible bug with ESBUILD_BINARY_PATH #121

Open
1 task
gonzojive opened this issue Feb 5, 2023 · 1 comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build

Comments

@gonzojive
Copy link

gonzojive commented Feb 5, 2023

What is the current behavior?

A platform-specific binary release of esbuild is downloaded and used for the esbuild binary. There are notes on how to configure a custom toolchain binary but no quick and easy code snippet.

I am able to get a custom version of esbuild working, but only with modifications of the rules_esbuild source (see #120 and in particular the change to esbuild.bzl, which seems necessary to properly set the ESBUILD_BINARY_PATH environment variable).

Describe the feature

Add a snippet that can be copy-pasted to easily use the version built from go source.

#120 allows an alternative binary to be specified like so:

esbuild_register_toolchains(
    name = "esbuild",
    esbuild_version = "0.17.5",
    target_tool = "@com_github_evanw_esbuild//cmd/esbuild",
)

Merging that PR (or something like it) is a possibility, I suppose.

Fund our work

@gonzojive gonzojive added the enhancement New feature or request label Feb 5, 2023
@alexeagle alexeagle added the funding needed Contribute to https://opencollective.com/aspect-build label Mar 27, 2023
@alexeagle
Copy link
Member

@gonzojive as soon as we figure out the question of your org submitting bug bounties, this would be a good candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants