Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't fork git merge-base #2

Open
aspiers opened this issue Jan 5, 2015 · 3 comments
Open

don't fork git merge-base #2

aspiers opened this issue Jan 5, 2015 · 3 comments
Labels
enhancement
Milestone
post-hackweek polish

Comments

@aspiers
Copy link
Owner

aspiers commented Jan 5, 2015

It should be possible to replace invocations of git merge-base with calls to the pygit2 API. This should speed things up a bit.
@aspiers
Copy link
Owner Author

aspiers commented Jan 6, 2015

Looks like proper merge-base support has only just reached libgit2 so won't be supported by pygit2 for a while.

@aspiers aspiers added this to the post-hackweek polish milestone Jan 9, 2015
@waldyrious
Copy link

waldyrious commented Apr 11, 2017 •
edited
Loading

According to https://github.com/libgit2/pygit2#0220-2015-01-16, it looks like pygit2 adopted that version of libgit2 only a few days after this issue was submitted :) But you know that, since you commented on libgit2/pygit2#459, so I'm confused now about whether that's the right release.

In any case, I suppose since then the change has indeed propagated to pygit2 regardless. Should the "blocked" label be removed from this issue?

@aspiers aspiers removed the blocked label Apr 11, 2017
@aspiers
Copy link
Owner Author

aspiers commented Apr 11, 2017

Yep, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
post-hackweek polish
Development

No branches or pull requests
2 participants
@aspiers @waldyrious