Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parsing doesn't handle DateTimeOffset with timezone #16441

Closed
SteveSandersonMS opened this issue Mar 8, 2018 · 3 comments
Closed

JSON parsing doesn't handle DateTimeOffset with timezone #16441

SteveSandersonMS opened this issue Mar 8, 2018 · 3 comments
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components

Comments

@SteveSandersonMS
Copy link
Member

Currently for DateTimeOffset, SimpleJson has:

DateTimeOffset.ParseExact(str, Iso8601Format, CultureInfo.InvariantCulture, ...

But the Iso8601Format value doesn't allow for timezone offsets, so it can't ParseExact.

We should amend SimpleJson for DateTimeOffset in the same way we did for DateTime to make it more flexible about incoming formats.
@danroth27
Copy link
Member

@JamesNK What if we had a dev who was really good at JSON parsing and wanted to make the web a better place . . . 😃

@SteveSandersonMS
Copy link
Member Author

I'm pretty sure @JamesNK has already solved this problem quite thoroughly!

@JamesNK
Copy link
Member

JamesNK commented Mar 8, 2018

What's a JSON?

SteveSandersonMS referenced this issue in SteveSandersonMS/BlazorMigration Nov 27, 2018
@SteveSandersonMS
In JsonUtil, support DateTimeOffset. Fixes #218.
4202a6c
@mkArtakMSFT mkArtakMSFT transferred this issue from dotnet/blazor Oct 27, 2019
@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Oct 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JamesNK @SteveSandersonMS @danroth27 @mkArtakMSFT