This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Eliminate wrapper elements #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ently, implementation is still backed by the same underlying DOM APIs
…se comment nodes as containers)
|
Yay! Keep up the good work! |
|
This is great news. Looking forward to future progress. |
SteveSandersonMS
added a commit
to SteveSandersonMS/BlazorMigration
that referenced
this pull request
Nov 27, 2018
* Factor out all DOM-structure modifying code into an abstraction. Currently, implementation is still backed by the same underlying DOM APIs * Implement LogicalElement properly (store hierarchy in own property; use comment nodes as containers) * In LogicalElement, be explicit about unsupported scenarios * Update E2E tests to stop assuming existence of wrapper elements * Where supported, store private properties using opaque symbols as keys
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384. In fact it goes further and eliminates the wrapper elements in all scenarios, not just when components produce exactly one top-level node.
This PR changes how
BrowserRendererworks so that it no longer inserts the extrablazor-componentelements around child components. This simplifies the DOM structure, but more importantly, simplifies working with CSS because you no longer have to account for the wrappers in your selectors. The DOM structure is now completely under the control of the developer. For details on how this works (and how it preserves O(1) traversal), see the comments insideLogicalElement.ts.All future DOM mutation logic in
BrowserRenderermust use theLogicalElementAPIs (unstead of directly calling native DOM insertion/removal APIs) to retain compatibility.