Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Support custom events and non-bubbling standard events #722

Merged
merged 3 commits into from
May 1, 2018

Conversation

SteveSandersonMS
Copy link
Member

... in addition to the existing support for bubbling standard events.

@SteveSandersonMS
Copy link
Member Author

@rynowak Hopefully this covers what you need to get the remaining event types working end-to-end.

@@ -0,0 +1,34 @@
<h3>Bubbling standard event</h3>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rynowak I now realise this E2E test duplicates some of what you're adding in #718. Hopefully we can combine the two sets of tests. I'm happy to rename this file and its corresponding EventTest.cs.

Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. thanks for getting to this

@SteveSandersonMS SteveSandersonMS force-pushed the stevesa/support-non-bubbling-events branch from 433be38 to 2de7dc4 Compare May 1, 2018 15:45
@SteveSandersonMS SteveSandersonMS merged commit 138fa6b into dev May 1, 2018
@SteveSandersonMS SteveSandersonMS deleted the stevesa/support-non-bubbling-events branch May 1, 2018 16:12
@SteveSandersonMS
Copy link
Member Author

@rynowak I also renamed the E2E test files so they won't clash with your PR #718.

@SteveSandersonMS SteveSandersonMS added this to the 0.3.0 milestone May 1, 2018
SteveSandersonMS added a commit to SteveSandersonMS/BlazorMigration that referenced this pull request Nov 27, 2018
* Support non-bubbling events

* Support responding to arbitrary events. E2E coverage of this and bubbling.

* Rename E2E test files to avoid clash with other PR
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants