This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 649
Support custom events and non-bubbling standard events #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rynowak Hopefully this covers what you need to get the remaining event types working end-to-end. |
SteveSandersonMS
commented
May 1, 2018
@@ -0,0 +1,34 @@ | |||
<h3>Bubbling standard event</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rynowak
approved these changes
May 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. thanks for getting to this
SteveSandersonMS
force-pushed
the
stevesa/support-non-bubbling-events
branch
from
May 1, 2018 15:45
433be38
to
2de7dc4
Compare
SteveSandersonMS
added a commit
to SteveSandersonMS/BlazorMigration
that referenced
this pull request
Nov 27, 2018
* Support non-bubbling events * Support responding to arbitrary events. E2E coverage of this and bubbling. * Rename E2E test files to avoid clash with other PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in addition to the existing support for bubbling standard events.