Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Update package TFM for 2.0 #281

Closed
natemcmaster opened this issue Mar 22, 2017 · 3 comments
Closed

Update package TFM for 2.0 #281

natemcmaster opened this issue Mar 22, 2017 · 3 comments
Assignees
@natemcmaster
Labels
3 - Done closed-fixed
Milestone
2.0.0-preview1

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Mar 22, 2017 •
edited
Loading

The design for DotNetCliToolReference packages is still unclear. Not sure if we should target netcoreapp1.0 or netcoreapp2.0. At the moment, packages target netcoreapp1.0 even though the tool runs on netcoreapp2.0.

Changing the package to anything except netcoreapp1.0 causes dotnet-restore to fail. See NuGet/Home#4396
@natemcmaster natemcmaster self-assigned this Mar 22, 2017
@natemcmaster natemcmaster changed the title [tracker] Update package TFM for 2.0 (maybe?) Update package TFM for 2.0 (maybe?) Mar 22, 2017
@Eilon Eilon mentioned this issue Mar 24, 2017
Merged
@natemcmaster
Copy link
Contributor Author

cc @prafullbhosale

@prafullbhosale prafullbhosale mentioned this issue Apr 3, 2017
Closed
@muratg muratg added this to the 2.0.0 milestone Apr 13, 2017
@natemcmaster natemcmaster mentioned this issue Apr 24, 2017
Merged
@natemcmaster natemcmaster changed the title Update package TFM for 2.0 (maybe?) Update package TFM for 2.0 Apr 24, 2017
@natemcmaster natemcmaster modified the milestones: 2.0.0-preview1, 2.0.0 Apr 25, 2017
@cesarblum
Copy link
Contributor

I have an app targeting netcoreapp2.0 and I'm seeing this error after this change:

C:\Users\cesars\.dotnet\x64\sdk\2.0.0-preview1-005825\NuGet.targets(97,5): error : Package Microsoft.Extensions.SecretManager.Tools 2.0.0-preview1-24645 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package Microsoft.Extensions.SecretManager.Tools 2.0.0-preview1-24645 supports: netcoreapp2.0 (.NETCoreApp,Version=v2.0) [D:\src\aspnet\MetaPackages\samples\AppSettings\AppSettings.csproj]

@natemcmaster
Copy link
Contributor Author

It should be resolved when dotnet/cli#6356 is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@natemcmaster natemcmaster

Labels
3 - Done closed-fixed
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@cesarblum @muratg @natemcmaster